Born in Hong Kong, he was a composer. In 1939, he studied composition under Tan Xiaolin at the Shanghai Conservatory of Music, where he learned Paul Hindemith's compositional techniques. After graduation, he held teaching positions in various locations including Hong Kong, Guangdong Province, Sichuan Province, and Shanghai. After 1949, he taught at the Central Conservatory of Music, dedicating himself to nurturing the next generation of musicians. In the 1980s, he returned to Hong Kong and taught at Hong Kong Baptist University until his retirement.